repl: remove deprecated repl features #33286

BridgeAR · 2020-05-07T18:38:29Z

repl: remove deprecated .rli

The .rli property is just a reference to the active REPL instance
and it was deprecated for a long time.

To improve maintainability of the REPL this feature is removed.

repl: remove deprecated bufferedCommand property

This property is deprecated since Node.js v9.0.0 and to improve
maintainability of the REPL it is now removed.

repl: remove deprecated repl.parseREPLKeyword() function

This removes the deprecated REPLServer.parseREPLKeyword function. It
is deprecated for a long time and should not provide any benefit to
users. To improve the maintainability of the REPL module, it's now
removed.

repl: remove deprecated repl.turnOffEditorMode() function

This function is deprecated for multiple years and provides very
little benefit to users. Thus, it's removed to improve the
maintainability of the REPL module.

repl: remove deprecated repl.memory function

This removes the memory function. It is deprecated for a long time
while not being really helpful being exposed. Thus, it is removed
to improve maintainability of the REPL module.

@nodejs/repl PTAL

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-05-08T15:19:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31241/ ✔️ (yellow build)
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2379/ ✅

nodejs-github-bot · 2020-05-09T23:14:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31261/

BridgeAR · 2020-05-09T23:35:27Z

@nodejs/repl @nodejs/tsc PTAL. CITGM looks good.

Trott · 2020-05-10T03:06:04Z

@nodejs/repl @nodejs/tsc PTAL. CITGM looks good.

LGTM but I'd prefer to let someone with more REPL domain knowledge weigh in first. (But if that doesn't happen, I'll +1 this to help avoid it getting completely stalled.)

doc/api/deprecations.md

nodejs-github-bot · 2020-05-11T13:05:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31273/

nodejs-github-bot · 2020-05-15T12:48:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31348/

nodejs-github-bot · 2020-05-16T08:52:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31355/

The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

This removes the deprecated REPLServer.parseREPLKeyword function. It is deprecated for a long time and should not provide any benefit to users. To improve the maintainability of the REPL module, it's now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot · 2020-05-18T01:27:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31377/

This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot · 2020-05-18T01:32:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31378/

nodejs-github-bot · 2020-05-18T22:12:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31395/

nodejs-github-bot · 2020-05-20T15:05:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31450/

The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This removes the deprecated REPLServer.parseREPLKeyword function. It is deprecated for a long time and should not provide any benefit to users. To improve the maintainability of the REPL module, it's now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2020-05-23T01:13:08Z

Landed in e88d098...a416692

The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This removes the deprecated REPLServer.parseREPLKeyword function. It is deprecated for a long time and should not provide any benefit to users. To improve the maintainability of the REPL module, it's now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

BridgeAR requested review from lance, jasnell and targos May 7, 2020 18:38

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label May 7, 2020

mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 7, 2020

targos approved these changes May 10, 2020

View reviewed changes

BridgeAR force-pushed the remove-deprecated-repl-functions branch from 8c9db59 to 046721d Compare May 11, 2020 13:03

jasnell approved these changes May 11, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2020

BridgeAR force-pushed the remove-deprecated-repl-functions branch from 046721d to 0455535 Compare May 15, 2020 12:48

BridgeAR added 4 commits May 18, 2020 03:22

repl: remove deprecated .rli

4213553

The .rli property is just a reference to the active REPL instance and it was deprecated for a long time. To improve maintainability of the REPL this feature is removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

repl: remove deprecated bufferedCommand property

cc52579

This property is deprecated since Node.js v9.0.0 and to improve maintainability of the REPL it is now removed. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

repl: remove deprecated repl.turnOffEditorMode() function

01d9322

This function is deprecated for multiple years and provides very little benefit to users. Thus, it's removed to improve the maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR force-pushed the remove-deprecated-repl-functions branch from 0455535 to 551f4c4 Compare May 18, 2020 01:22

repl: remove deprecated repl.memory function

eae6e38

This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR force-pushed the remove-deprecated-repl-functions branch from 551f4c4 to eae6e38 Compare May 18, 2020 01:29

BridgeAR closed this May 23, 2020

BethGriggs mentioned this pull request Sep 1, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

5hanth mentioned this pull request Nov 19, 2020

repl breaks on Node v15.0.0 TypeError: Cannot set property 'history' of undefined adonisjs/adonis-cli#190

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: remove deprecated repl features #33286

repl: remove deprecated repl features #33286

BridgeAR commented May 7, 2020 •

edited

Loading

nodejs-github-bot commented May 8, 2020 •

edited by BridgeAR

Loading

nodejs-github-bot commented May 9, 2020

BridgeAR commented May 9, 2020

Trott commented May 10, 2020

nodejs-github-bot commented May 11, 2020

nodejs-github-bot commented May 15, 2020

nodejs-github-bot commented May 16, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 20, 2020

BridgeAR commented May 23, 2020

repl: remove deprecated repl features #33286

repl: remove deprecated repl features #33286

Conversation

BridgeAR commented May 7, 2020 • edited Loading

repl: remove deprecated .rli

repl: remove deprecated bufferedCommand property

repl: remove deprecated repl.parseREPLKeyword() function

repl: remove deprecated repl.turnOffEditorMode() function

repl: remove deprecated repl.memory function

Checklist

nodejs-github-bot commented May 8, 2020 • edited by BridgeAR Loading

nodejs-github-bot commented May 9, 2020

BridgeAR commented May 9, 2020

Trott commented May 10, 2020

nodejs-github-bot commented May 11, 2020

nodejs-github-bot commented May 15, 2020

nodejs-github-bot commented May 16, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 18, 2020

nodejs-github-bot commented May 20, 2020

BridgeAR commented May 23, 2020

BridgeAR commented May 7, 2020 •

edited

Loading

nodejs-github-bot commented May 8, 2020 •

edited by BridgeAR

Loading