Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove unused _transformState #33105

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 27, 2020

_transformState is no longer used since Transform was simplified.

Refs: #32763

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

_transformState is no longer used since Transform was
simplified.

Refs: nodejs#32763
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Apr 27, 2020
@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

@nodejs/streams

@lpinca
Copy link
Member

lpinca commented Apr 28, 2020

I wonder if _transformState is used in the wild, otherwise LGTM.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Does this depend on a semver-major commit?

@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

@mcollina: yes, #32763 is semver-major

@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

Did #32763 land on v14?

@jasnell
Copy link
Member

jasnell commented Apr 28, 2020

Oy, I wish I had caught #32763 before it landed. Even tho _transformState was a private property, the fact that it was public for so long really means that it should ideally have gone through a deprecation cycle as opposed to being removed immediately. I just confirmed that _transformState is still present in Node.js 14.0.0. I absolutely think we should follow a proper runtime deprecation cycle for _transformState in 14.x.

@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

@jasnell: I'll open a separate PR for runtime deprecation against v14. Can it still land there though?

@jasnell
Copy link
Member

jasnell commented Apr 28, 2020

The @nodejs/tsc will have to decide. We've done it before.

@ronag
Copy link
Member Author

ronag commented Apr 30, 2020

@mcollina: Was that lgtm an approve?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, yes

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2020
@nodejs-github-bot
Copy link
Collaborator

@ronag
Copy link
Member Author

ronag commented Apr 30, 2020

Landed in e10e292

@ronag ronag closed this Apr 30, 2020
ronag added a commit that referenced this pull request Apr 30, 2020
_transformState is no longer used since Transform was
simplified.

Refs: #32763

PR-URL: #33105
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ronag added a commit to nxtedition/node that referenced this pull request Jun 28, 2020
Transform._transformState is removed in future version as part
of a refactoring.

Refs: nodejs#32763
Refs: nodejs#33105 (comment)
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Transform._transformState is removed in future version as part
of a refactoring.

Refs: #32763
Refs: #33105 (comment)

Backport-PR-URL: #33126
PR-URL: #32763
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Transform._transformState is removed in future version as part
of a refactoring.

Refs: #32763
Refs: #33105 (comment)

Backport-PR-URL: #33126
PR-URL: #32763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants