Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: use autoDestroy: true in incoming message #33035

Closed
wants to merge 7 commits into from
Closed

http: use autoDestroy: true in incoming message #33035

wants to merge 7 commits into from

Commits on Dec 9, 2020

  1. http: use autoDestroy: true in incoming message 

    Enable the default `autoDestroy: true` option in IncomingMessage.

Refactor `_http_client` and `_http_server` to remove any manual
destroying/closing of IncomingMessage.
Refactor IncomingMessage `destroy` method to use the standard
implementation of the stream module and move the early termination
event emitting inside of it.
    @dnlup
    dnlup committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    dd5a840 View commit details
    Browse the repository at this point in the history

  2. http: reafactor incoming message destroy 

    Destroy the underlying socket only if it is not ready destroyed. Wait
for the stream to finish in that case.
    @dnlup
    dnlup committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    a8ea86e View commit details
    Browse the repository at this point in the history

  3. http: fix lint error in incoming message

    @dnlup
    dnlup committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    1187814 View commit details
    Browse the repository at this point in the history

  4. http: add comments in _http_incoming

    @dnlup
    dnlup committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    a5c6690 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. http: remove trailing space

    @dnlup
    dnlup committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    f60ffd0 View commit details
    Browse the repository at this point in the history

  2. http: use standard args order in IncomingMEssage onError

    @dnlup
    dnlup committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    5806655 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. http: add test for incomingmessage destroy 

    Test uncaught exceptions when destroying IncomingMessage.
    @dnlup
    dnlup committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    df7ce62 View commit details
    Browse the repository at this point in the history