lib: fix memory leak, when module require error occurs #32837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianxuify
commented
Apr 14, 2020
| @@ -302,17 +302,14 @@ assert.throws( | |||
| } | |||
| }, | |||
| 'fixtures/path.js': {}, | |||
| 'fixtures/throws_error.js': {}, | |||
There was a problem hiding this comment.
Unit test for module loading, verify module.children contains all the different modules that we've required, but should not contain modules that failed to load
bnoordhuis
approved these changes
Apr 14, 2020
Delete useless module in parent module: parent.children array when error occuers so that the memory can be garbage collected. Fixes: nodejs#32836
lianxuify
force-pushed
the
module_memory_leak
branch
from
e3b195b to
d0b97d7
Compare
bnoordhuis
approved these changes
Apr 15, 2020
puzpuzpuz
approved these changes
Apr 15, 2020
puzpuzpuz
added
module
|
Landed in 6bcf968 I have slightly modified the prefix and detailed explanation in the commit message to make it more obvious. Hope you don't mind. Once again, thanks for noticing and fixing this issue! |
Thank you for your modification, I learned. |
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: nodejs#32836 PR-URL: nodejs#32837 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete useless module in parent module: parent.children array when error occuers
so that the memory can be garbage collected.
Fixes: #32836
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes