Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make README(.md) more informative by indicating that a GPG key u… #32591

Closed

Conversation

haqer1
Copy link
Contributor

@haqer1 haqer1 commented Apr 1, 2020

…sed to sign a release could be a sub-key of a key listed in README(.md) (which itself isn't listed in it)

Update README.md.

Fixes: #32559

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 1, 2020
…sed to sign a release could be a sub-key of a key listed in README(.md) (which itself isn't listed in it)

Update README.md.

Fixes: nodejs#32559
…d to import a key used to sign a release & check whether it is a sub-key of a primary key listed in README(.md) (which itself isn't listed in it)...

Addition README.md update

Fixes: nodejs#32559
@haqer1 haqer1 force-pushed the signing-key-fixup-alternative-approach-2 branch from 9949a61 to fa68553 Compare April 1, 2020 05:10
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think it is reasonable to mention subkeys in this section I think the currently proposed copy could be more succinct.

I've made proposed an alternative but am also willing to review another iteration. Not blocking current copy, but I do think there is room for improvement.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
haqer1 and others added 2 commits April 4, 2020 15:48
Co-Authored-By: Myles Borins <myles.borins@gmail.com>
Co-Authored-By: Myles Borins <myles.borins@gmail.com>
@haqer1 haqer1 force-pushed the signing-key-fixup-alternative-approach-2 branch from 0e9ab47 to 333072c Compare April 4, 2020 09:50
@haqer1
Copy link
Contributor Author

haqer1 commented Apr 4, 2020

I've committed the suggested changes to simplify landing of this PR (part 1).

That said, i think part 2 is needed:
either PR #32654 or PR #32655.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request Apr 14, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

Landed in ee5c836

MylesBorins pushed a commit that referenced this pull request Apr 17, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
PR-URL: nodejs#32591
Fixes: nodejs#32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
targos pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32591
Fixes: #32559
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
6 participants