Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-worker-prof flaky on linux #32589

Closed
wants to merge 1 commit into from
Closed

test: mark test-worker-prof flaky on linux #32589

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: #26401

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 31, 2020
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 31, 2020
@MylesBorins
Copy link
Contributor Author

fast-track please

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30294/

richardlau
richardlau approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could alternatively add as a SLOW test in https://github.com/nodejs/node/blob/master/test/root.status which would skip it in the debug containered CI.

@MylesBorins MylesBorins mentioned this pull request Mar 31, 2020
Closed
3 tasks
@MylesBorins
test: add test-worker-prof to the SLOW list for debug
91bdc35 
Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: nodejs#26401
@MylesBorins MylesBorins force-pushed the test-worker-prof-flake branch from 1266676 to 91bdc35 Compare March 31, 2020 22:37
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30295/

@MylesBorins
Copy link
Contributor Author

@richardlau I've updated with your suggestion, seems more appropriate

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30296/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30311/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30318/

@richardlau richardlau mentioned this pull request Apr 1, 2020
Open
4 tasks
MylesBorins added a commit that referenced this pull request Apr 1, 2020
@MylesBorins
test: add test-worker-prof to the SLOW list for debug
18b3383 
Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: #26401

PR-URL: #32589
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in 18b3383

@MylesBorins MylesBorins closed this Apr 1, 2020
MylesBorins added a commit that referenced this pull request Apr 1, 2020
@MylesBorins
test: add test-worker-prof to the SLOW list for debug
6f50b60 
Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: #26401

PR-URL: #32589
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@codebytere codebytere mentioned this pull request Apr 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@MylesBorins @BethGriggs
test: add test-worker-prof to the SLOW list for debug
440e1ad 
Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: #26401

PR-URL: #32589
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@MylesBorins @targos
test: add test-worker-prof to the SLOW list for debug
ca26620 
Consistently failing on ubuntu1804_sharedlibs_debug_x64

Refs: #26401

PR-URL: #32589
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
@targos targos mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MylesBorins @nodejs-github-bot @sam-github @richardlau @gireeshpunathil