Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify listening event #32581

Closed
wants to merge 2 commits into from

Conversation

HarshithaKP
Copy link
Member

Co-authored-by: Divyanshu dsinecos@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Co-authored-by: Divyanshu <dsinecos@gmail.com>
@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Mar 31, 2020
@HarshithaKP
Copy link
Member Author

This is rework of PR : #23959

doc/api/dgram.md Outdated Show resolved Hide resolved
doc/api/dgram.md Outdated Show resolved Hide resolved
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Apr 5, 2020
addaleax pushed a commit that referenced this pull request Apr 7, 2020
Co-authored-by: Divyanshu <dsinecos@gmail.com>

PR-URL: #32581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

addaleax commented Apr 7, 2020

Landed in 8c12a08

@addaleax addaleax closed this Apr 7, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
Co-authored-by: Divyanshu <dsinecos@gmail.com>

PR-URL: #32581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Co-authored-by: Divyanshu <dsinecos@gmail.com>

PR-URL: #32581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
Co-authored-by: Divyanshu <dsinecos@gmail.com>

PR-URL: #32581
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants