Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: add pipeline test for destroy of returned stream #32425

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 22, 2020

Adds a test to ensure that destroying the returned stream
of pipeline will cause a premature close error.

Was unsure whether this was the case and didn't find a test for it so I thought I might as well add one.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Adds a test to ensure that destroying the returned stream
of pipeline will cause a premature close error.
@ronag ronag added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Mar 22, 2020
@ronag ronag requested review from mcollina and lpinca March 22, 2020 16:45
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
Member Author

ronag commented Mar 25, 2020

Landed in 9e3eddc

@ronag ronag closed this Mar 25, 2020
ronag added a commit that referenced this pull request Mar 25, 2020
Adds a test to ensure that destroying the returned stream
of pipeline will cause a premature close error.

PR-URL: #32425
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 25, 2020
Adds a test to ensure that destroying the returned stream
of pipeline will cause a premature close error.

PR-URL: #32425
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants