Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix CAs missing from secure contexts #32315

Closed
wants to merge 4 commits into from
Closed

src: fix CAs missing from secure contexts #32315

wants to merge 4 commits into from

Commits on Mar 26, 2020

  1. src: fix CAs missing from secure contexts 

    Adds CAs from NODE_EXTRA_CA_CERTS to root_certs_vector in node_crypto.cc so that the extra certificates are always added to SecureContext instances.

tls.rootCertificates restored to previous behavior of returning built-in Node.js certificates when --openssl-use-def-ca-store CLI option is  set.

Fixes: nodejs#32229
Fixes: nodejs#32010
Refs: nodejs#32075
    @ebickle @MylesBorins
    ebickle authored and MylesBorins committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    1b0f50b View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. src: fix CAs missing from secure contexts 

    Adds CAs from NODE_EXTRA_CA_CERTS to root_certs_vector in node_crypto.cc so that the extra certificates are always added to SecureContext instances.

tls.rootCertificates restored to previous behavior of returning built-in Node.js certificates when --openssl-use-def-ca-store CLI option is  set.

Fixes: nodejs#32229
Fixes: nodejs#32010
Refs: nodejs#32075
    @ebickle
    ebickle committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    d6b075d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/missing-rootcertificates-2' of https://github.com/e… 

    …bickle/node into fix/missing-rootcertificates-2
    @ebickle
    ebickle committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6743db2 View commit details
    Browse the repository at this point in the history

  3. src: improve code formatting of node_crypto.cc 

    Removed extraneous braces and superfluous scope comments.
    @ebickle
    ebickle committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    7c337f7 View commit details
    Browse the repository at this point in the history