v12.16.2 proposal

.eslintrc.js

@@ -244,6 +244,10 @@ module.exports = {
         selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
         message: 'The first argument should be the `actual`, not the `expected` value.',
       },
+      {
+        selector: "CallExpression[callee.name='isNaN']",
+        message: 'Use Number.isNaN() instead of the global isNaN() function.',
+      },
     ],
     /* eslint-enable max-len */
     'no-return-await': 'error',

.github/ISSUE_TEMPLATE/1-bug-report.md

@@ -5,20 +5,47 @@ about: Create a report to help us improve
 ---
 
 <!--
-Thank you for reporting a possible bug in Node.js.
+Thank you for reporting an issue.
 
-Please fill in as much of the template below as you can.
+This issue tracker is for bugs and issues found within Node.js core.
+If you require more general support please file an issue on our help
+repo. https://github.com/nodejs/help
+
+
+Please fill in as much of the template below as you're able.
 
 Version: output of `node -v`
 Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
-Subsystem: if known, please specify the affected core module name
-
-If possible, please provide code that demonstrates the problem, keeping it as
-simple and free of external dependencies as you can.
+Subsystem: if known, please specify affected core module name
 -->
 
 * **Version**:
 * **Platform**:
 * **Subsystem**:
 
-<!-- Please provide more details below this comment. -->
+### What steps will reproduce the bug?
+
+<!--
+Enter details about your bug, preferably a simple code snippet that can be
+run using `node` directly without installing third-party dependencies.
+-->
+
+### How often does it reproduce? Is there a required condition?
+
+### What is the expected behavior?
+
+<!--
+If possible please provide textual output instead of screenshots.
+-->
+
+### What do you see instead?
+
+<!--
+If possible please provide textual output instead of screenshots.
+-->
+
+### Additional information
+
+<!--
+Tell us anything else you think we should know.
+-->

.github/workflows/build-windows.yml

@@ -0,0 +1,23 @@
+name: build-windows
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: 2.7
+  FLAKY_TESTS: dontcare
+
+jobs:
+  build-windows:
+    runs-on: windows-2016
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Install deps
+        run: choco install nasm
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: ./vcbuild.bat

.github/workflows/linters.yml

@@ -0,0 +1,73 @@
+name: linters
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: 3.8
+  NODE_VERSION: 10.x
+
+jobs:
+  lint-addon-docs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint addon docs
+        run: NODE=$(which node) make lint-addon-docs
+  lint-cpp:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint C/C++ files
+        run: make lint-cpp
+  lint-md:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint docs
+        run: |
+          echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
+          NODE=$(which node) make lint-md
+  lint-js:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint JavaScript files
+        run: NODE=$(which node) make lint-js
+  lint-py:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Lint Python
+        run: |
+          make lint-py-build || true
+          NODE=$(which node) make lint lint-py

.github/workflows/misc.yml

@@ -0,0 +1,24 @@
+name: misc
+
+on: [push, pull_request]
+
+env:
+  NODE_VERSION: 12.x
+
+jobs:
+  build-docs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: NODE=$(which node) make doc-only
+      - uses: actions/upload-artifact@v1
+        with:
+          name: docs
+          path: out/doc

.github/workflows/pythonpackage.yml

@@ -0,0 +1,33 @@
+name: Python 3 testing
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      max-parallel: 1
+      matrix:
+        python-version: [3.8]  # [2.7, 3.5, 3.6, 3.7]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Compile Node.js
+      run: |
+        python ./configure.py
+        make -j2 V=1
+    - name: Test JS Suites
+      run: |
+        python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare default
+    - name: Test C++ Suites
+      run: |
+        make -j1 V=1 test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
+        python tools/test.py -j 2 -p dots --report --mode=release --flaky-tests=dontcare addons js-native-api node-api
+    - name: Make lint
+      run: |
+        make lint-py-build || true
+        NODE=$(which node) make lint lint-py

.github/workflows/remark-lint-problem-matcher.json

@@ -0,0 +1,22 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "remark-lint",
+      "pattern": [
+        {
+          "regexp": "^(?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)*$",
+          "file": 1
+        },
+        {
+          "regexp": "^\\s+(?:\\d+:\\d+-)?(\\d+):(\\d+)\\s+\\S*(error|warning|info)\\S*\\s+(.+)\\s+(\\S+)\\s+(?:\\S+)$",
+          "line": 1,
+          "column": 2,
+          "severity": 3,
+          "message": 4,
+          "code": 5,
+          "loop": true
+        }
+      ]
+    }
+  ]
+}

.github/workflows/test-linux.yml

@@ -0,0 +1,23 @@
+name: test-linux
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: 2.7
+  FLAKY_TESTS: dontcare
+
+jobs:
+  test-linux:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: make build-ci -j2 V=1
+      - name: Test
+        run: make run-ci -j2 V=1

.github/workflows/test-macos.yml

@@ -0,0 +1,23 @@
+name: test-macOS
+
+on: [push, pull_request]
+
+env:
+  PYTHON_VERSION: 2.7
+  FLAKY_TESTS: dontcare
+
+jobs:
+  test-macOS:
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ env.PYTHON_VERSION }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ env.PYTHON_VERSION }}
+      - name: Environment Information
+        run: npx envinfo
+      - name: Build
+        run: make build-ci -j8 V=1
+      - name: Test
+        run: make run-ci -j8 V=1

.gitignore

@@ -19,7 +19,6 @@
 !.gitkeep
 !.mailmap
 !.nycrc
-!.travis.yml
 !.eslintrc.yaml
 !.cpplint
 
@@ -33,6 +32,7 @@
 /doc/api.xml
 /node
 /node_g
+/gon-config.json
 /*.exe
 /*.swp
 /out
@@ -45,8 +45,8 @@
 /config_fips.gypi
 
 # === Rules for MSVS artifacts ===
-/Debug
-/Release
+Debug/
+Release/
 *.sln
 *.suo
 *.vcxproj*

.mailmap

@@ -423,6 +423,7 @@ Wilson Lin <wla80@sfu.ca>
 Wyatt Preul <wpreul@gmail.com> geek <wpreul@gmail.com>
 Xavier J Ortiz <xavier.ortiz.ch@gmail.com>
 xiaoyu <306766053@qq.com> Poker <306766053@qq.com>
+Yael Hermon <yaelherm@gmail.com> <yaelhe@wix.com>
 Yazhong Liu <yorkiefixer@gmail.com> Yazhong Liu <l900422@vip.qq.com>
 Yazhong Liu <yorkiefixer@gmail.com> Yorkie <l900422@vip.qq.com>
 Yazhong Liu <yorkiefixer@gmail.com> Yorkie <yorkiefixer@gmail.com>