Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v13.x backport] stream: avoid destroying writable source #32211

Closed
wants to merge 1 commit into from
Closed

[v13.x backport] stream: avoid destroying writable source #32211

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 11, 2020

PR-URL: #32198

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag requested a review from MylesBorins March 11, 2020 17:59
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29755/

@ronag
stream: avoid destroying writable source
a0f3d2b 
User might still want to be able to use the writable side
of src. This is in the case where e.g. the Duplex input
is not directly connected to its output. Such a case could
happen when the Duplex is reading from a socket and then echos
the data back on the same socket.

Fixes: nodejs@4d93e10#commitcomment-37751035

Backport-PR-URL: nodejs#32211
@ronag
Copy link
Member Author

ronag commented Mar 11, 2020

fixed conflict

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29757/

@ronag
Copy link
Member Author

ronag commented Mar 11, 2020

included in #32212 in order to avoid multiple steps of conflicts

@ronag ronag closed this Mar 11, 2020
@ronag ronag mentioned this pull request Mar 11, 2020
Closed
4 tasks
@szmarczak szmarczak mentioned this pull request Mar 12, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins Awaiting requested review from MylesBorins

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @nodejs-github-bot