Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add WASI test for path_link() #32132

Merged
merged 1 commit into from
Mar 8, 2020
Merged

test: add WASI test for path_link() #32132

merged 1 commit into from
Mar 8, 2020

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 6, 2020

This PR adds missing coverage for the WASI path_link() function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29598/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29600/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 7, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29601/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 7, 2020
@cjihrig
test: add WASI test for path_link()
aa3360f 
PR-URL: nodejs#32132
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@cjihrig cjihrig merged commit aa3360f into nodejs:master Mar 8, 2020
@cjihrig cjihrig deleted the wasi-link-test branch March 8, 2020 19:13
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@cjihrig @MylesBorins
test: add WASI test for path_link()
1428de8 
PR-URL: #32132
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 16, 2020
@cjihrig @codebytere
test: add WASI test for path_link()
1388fb1 
PR-URL: #32132
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @codebytere
test: add WASI test for path_link()
3f0d002 
PR-URL: #32132
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@cjihrig @codebytere
test: add WASI test for path_link()
1318662 
PR-URL: #32132
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @nodejs-github-bot @devnexen @richardlau