Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move Glen Keane to Collaborator Emeritus #31993

Closed
wants to merge 0 commits into from
Closed

meta: move Glen Keane to Collaborator Emeritus #31993

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 28, 2020

In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 28, 2020
@Trott
Copy link
Member Author

Trott commented Feb 28, 2020

@GlenTiki

MylesBorins
MylesBorins approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for the hard work!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2020
@GlenTiki
Copy link
Contributor

Thank you!

Trott added a commit to Trott/io.js that referenced this pull request Mar 1, 2020
@Trott
meta: move Glen Keane to Collaborator Emeritus
e57fbab 
In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

PR-URL: nodejs#31993
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott closed this Mar 1, 2020
@Trott
Copy link
Member Author

Trott commented Mar 1, 2020

Landed in e57fbab

@Trott Trott deleted the glentiki branch March 1, 2020 05:04
@codebytere codebytere mentioned this pull request Mar 3, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 3, 2020
@Trott @codebytere
meta: move Glen Keane to Collaborator Emeritus
91ce69a 
In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

PR-URL: #31993
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move Glen Keane to Collaborator Emeritus
48fde0d 
In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

PR-URL: #31993
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move Glen Keane to Collaborator Emeritus
bf21e5b 
In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

PR-URL: #31993
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move Glen Keane to Collaborator Emeritus
fd5c3a7 
In email, Glen confirmed that he is happy to move to Emeritus. He also
informed me that his handle is no longer thekemkid and is now glentiki.
At his request, I've updated the handle in the README in addition to
moving him to Emeritus.

PR-URL: #31993
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @GlenTiki @MylesBorins @lpinca @cjihrig @gireeshpunathil @nodejs-github-bot