Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: avoid resource reuse by FileHandle #31972

Closed
wants to merge 2 commits into from
Closed

async_hooks: avoid resource reuse by FileHandle #31972

wants to merge 2 commits into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 26, 2020

Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous.

Refs: #30959

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Feb 26, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29670/

@Flarna
Copy link
Member Author

Flarna commented Mar 9, 2020

Seems like something committed since my last commit caused the test to fail. will take a look...

@Flarna Flarna changed the title async_hooks: avoid resource reuse by FileHandle WIP: async_hooks: avoid resource reuse by FileHandle Mar 9, 2020
@Flarna
Copy link
Member Author

Flarna commented Mar 9, 2020

Seems the commit causing the test fails (missing destroy) is from #31869 (fyi @addaleax). Will further look into this tomorrow.

@Flarna
async_hooks: avoid resource reuse by FileHandle
d20000d 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.
@Flarna
use larger fixture
6e677da
@Flarna Flarna force-pushed the async-hooks-streampipe-reuse branch from eaf051f to 6e677da Compare March 10, 2020 07:43
@Flarna
Copy link
Member Author

Flarna commented Mar 10, 2020

Rebased and change to a larger fixture. Seems #31869 caused that less fileIO operations are done (2 instead 3). Using a larger fixture ensures that enough file io is done for the testcase.

@Flarna Flarna changed the title WIP: async_hooks: avoid resource reuse by FileHandle async_hooks: avoid resource reuse by FileHandle Mar 10, 2020
@Flarna Flarna requested a review from addaleax March 10, 2020 12:09
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29743/

@addaleax
Copy link
Member

Landed in c145b29

@addaleax addaleax closed this Mar 11, 2020
addaleax pushed a commit that referenced this pull request Mar 11, 2020
@Flarna @addaleax
async_hooks: avoid resource reuse by FileHandle
c145b29 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: #31972
Refs: #30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@Flarna Flarna deleted the async-hooks-streampipe-reuse branch March 11, 2020 18:33
MylesBorins pushed a commit that referenced this pull request Mar 11, 2020
@Flarna @MylesBorins
async_hooks: avoid resource reuse by FileHandle
478f1e7 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: #31972
Refs: #30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@MylesBorins MylesBorins mentioned this pull request Mar 12, 2020
Merged
@cjihrig cjihrig mentioned this pull request Mar 13, 2020
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Mar 15, 2020
@cjihrig
src: fix warn_unused_result compiler warning
8617508 
../src/node_file.cc:386:7: warning: ignoring return value of
function declared with 'warn_unused_result'
attribute [-Wunused-result]

PR-URL: nodejs#32241
Refs: nodejs#31972
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sthagen sthagen mentioned this pull request Mar 15, 2020
Merged
4 tasks
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@cjihrig @BridgeAR
src: fix warn_unused_result compiler warning
3c0ce69 
../src/node_file.cc:386:7: warning: ignoring return value of
function declared with 'warn_unused_result'
attribute [-Wunused-result]

PR-URL: #32241
Refs: #31972
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@cjihrig @MylesBorins
src: fix warn_unused_result compiler warning
7fc5e6d 
../src/node_file.cc:386:7: warning: ignoring return value of
function declared with 'warn_unused_result'
attribute [-Wunused-result]

PR-URL: #32241
Refs: #31972
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Flarna @targos
async_hooks: avoid resource reuse by FileHandle
146ad4e 
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: #31972
Refs: #30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
src: fix warn_unused_result compiler warning
9b6f678 
../src/node_file.cc:386:7: warning: ignoring return value of
function declared with 'warn_unused_result'
attribute [-Wunused-result]

PR-URL: #32241
Refs: #31972
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@Flarna Flarna mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Flarna @nodejs-github-bot @addaleax @Qard @jasnell @devnexen @BridgeAR @puzpuzpuz