Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add method links in dns.markdown #3196

Closed
wants to merge 1 commit into from
Closed

doc: add method links in dns.markdown #3196

wants to merge 1 commit into from

Conversation

a0viedo
Copy link
Member

@a0viedo a0viedo commented Oct 6, 2015

Added links to referenced methods and added parenthesis to follow consistency.

to perform name resolution in the same way that other applications on the same
operating system behave should use `dns.lookup`.__
operating system behave should use [`dns.lookup()`](#dns_dns_lookup_hostname_options_callback).__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are using the same thing again and again you can add the reference at the bottom.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye oh yeah I forgot about that, thanks.

Added links to referenced methods.
@mscdex mscdex added doc Issues and PRs related to the documentations. dns Issues and PRs related to the dns subsystem. labels Oct 6, 2015
@silverwind
Copy link
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Oct 9, 2015
Added links to referenced methods.

PR-URL: #3196
Reviewed-By: Roman Reiss <me@silverwind.io>>
@silverwind
Copy link
Contributor

Thanks! Landed in 70c78c9.

@silverwind silverwind closed this Oct 9, 2015
@a0viedo a0viedo deleted the patch-2 branch October 9, 2015 19:05
jasnell pushed a commit that referenced this pull request Oct 10, 2015
Added links to referenced methods.

PR-URL: #3196
Reviewed-By: Roman Reiss <me@silverwind.io>>
@jasnell
Copy link
Member

jasnell commented Oct 10, 2015

landed in v4.x in 6dd3476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants