tools: apply linting to custom rules code #3195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -505,7 +505,7 @@ bench-idle: | |||
| $(NODE) benchmark/idle_clients.js & | |||
|
|
|||
| jslint: | |||
| $(NODE) tools/eslint/bin/eslint.js src lib test --rulesdir tools/eslint-rules --reset --quiet | |||
| $(NODE) tools/eslint/bin/eslint.js src lib test tools/eslint-rules --rulesdir tools/eslint-rules --reset --quiet | |||
There was a problem hiding this comment.
Maybe put a break before --rulesdir.
|
LGTM |
|
New CI with line break added: https://ci.nodejs.org/job/node-test-pull-request/425/ |
|
LGTM |
|
Still LGTM BTW. |
|
Whoops, my bad on that style in that rule file. LGTM |
|
Landed in dbce29a |
Trott
added a commit
that referenced
this pull request
Oct 6, 2015
Apply our eslint rules to the code for our custom eslint rules. Eslint Inception! Maybe. I never saw that movie... PR-URL: #3195 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io>
Trott
added a commit
that referenced
this pull request
Oct 8, 2015
Apply our eslint rules to the code for our custom eslint rules. Eslint Inception! Maybe. I never saw that movie... PR-URL: #3195 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js project-specific estlint rules should maintain the style of the rest of the project JS code base.
Ref: #3157