Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: only lint markdown files that have changed (POSIX-only) #31923

Merged
merged 1 commit into from
Mar 1, 2020
Merged

build: only lint markdown files that have changed (POSIX-only) #31923

merged 1 commit into from
Mar 1, 2020

Commits on Mar 1, 2020

  1. build: only lint markdown files that have changed (POSIX-only) 

    Update Makefile so that only markdown files that have changed will be
linted. Currently, if one file in doc/api has changed, all files in
doc/api are linted.

On Windows, the lint-md task currently lints all files regardless of
whether any files has changed, and that behavior is unchanged here.

A further improvement is that when tools/lint-md.js is rebuilt, the
timestamp file is removed so that all files are linted again. This is
because rebuilding lint-md.js can introduce new rules or modify existing
rules, so re-linting everything helps make sure that accidental breakage
doesn't slip by unnoticed.

PR-URL: nodejs#31923
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    751c240 View commit details
    Browse the repository at this point in the history