New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.0.0-alpha.2 #31400

Closed

cjihrig wants to merge 5 commits into nodejs:master from cjihrig:eslint

Contributor

cjihrig commented Jan 17, 2020 •

edited

Loading

Update ESLint to 7.0.0-alpha.2

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot added the tools label

Member

Trott commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

Contributor Author

cjihrig commented Jan 17, 2020

Is the idea that this won't land until 7.0.0 is out and the PR will be updated to include that?

I'm fine with that approach. FWIW, in the past, we have updated to ESLint alpha releases as well.

BridgeAR approved these changes

View reviewed changes

Member

BridgeAR left a comment

RSLGTM

Landing the updates incrementally allows us to adjust everything during the individual release and we could already use the changed features. The eslints changes are normally very stable, no matter that it's an alpha. I am fine with waiting or landing it right away therefore.

BridgeAR added the author ready label

trivikr approved these changes

View reviewed changes

Member

trivikr left a comment

RSLGTM

Trott approved these changes

View reviewed changes

cjihrig force-pushed the eslint branch from 95232f7 to f5822bd Compare

February 15, 2020 14:55

cjihrig changed the title ~~tools: update ESLint to 7.0.0-alpha.0~~ tools: update ESLint to 7.0.0-alpha.1

cjihrig added 5 commits

February 28, 2020 17:03


          tools: update ESLint to 7.0.0-alpha.0

badac1f

Update ESLint to 7.0.0-alpha.0


          tools: update ESLint to 7.0.0-alpha.1

4f867fd

Update ESLint to 7.0.0-alpha.1


          tools: update ESLint to 7.0.0-alpha.2

78bceab

Update ESLint to 7.0.0-alpha.2


          tools: enable default-case-last lint rule

c6325e2


          tools: enable no-useless-backreference lint rule

0bc8fe0

cjihrig force-pushed the eslint branch from f5822bd to 0bc8fe0 Compare

February 28, 2020 23:38

cjihrig changed the title ~~tools: update ESLint to 7.0.0-alpha.1~~ tools: update ESLint to 7.0.0-alpha.2

This comment has been minimized.

Sign in to view

Collaborator

nodejs-github-bot commented Mar 9, 2020 •

edited by cjihrig

Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29667/ 💛

addaleax pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.0

7eaa813

Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.1

2348ca0

Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Member

addaleax commented Mar 11, 2020

Landed in 61f28fb...4f87b4f

addaleax pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.2

6712e4a

Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax pushed a commit that referenced this pull request


          tools: enable default-case-last lint rule

b4ca247

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

addaleax closed this

addaleax pushed a commit that referenced this pull request


          tools: enable no-useless-backreference lint rule

4f87b4f

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

cjihrig deleted the eslint branch

March 11, 2020 16:02

MylesBorins pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.0

c70cfd2

Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.1

cac1d01

Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.2

814bb4a

Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: enable default-case-last lint rule

d3c4210

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          tools: enable no-useless-backreference lint rule

35d0569

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins mentioned this pull request

v13.11.0 proposal #32185

Merged

targos pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.0

394fa1f

Update ESLint to 7.0.0-alpha.0

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.1

e641b3c

Update ESLint to 7.0.0-alpha.1

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request


          tools: update ESLint to 7.0.0-alpha.2

5dacfa7

Update ESLint to 7.0.0-alpha.2

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request


          tools: enable default-case-last lint rule

bcf152e

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request


          tools: enable no-useless-backreference lint rule

ecf842e

PR-URL: #31400
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos mentioned this pull request

v12.16.3 release proposal #33009

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready tools