Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] n-api: add napi_get_all_property_names #31384

Closed
wants to merge 1 commit into from
Closed

[v10.x] n-api: add napi_get_all_property_names #31384

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Co-Authored-By: @gabrielschulhof

PR-URL: #30006
Reviewed-By: @addaleax
Reviewed-By: @legendecas
Reviewed-By: @gabrielschulhof
Reviewed-By: @mhdawson
Reviewed-By: @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Jan 16, 2020
@gabrielschulhof gabrielschulhof added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 16, 2020
mhdawson
mhdawson approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28597/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28612/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28740/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28746/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28751/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28768/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29146/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 25, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29348/ ✅

@BethGriggs
Copy link
Member

@gabrielschulhof would you be able to take a look at the conflicts? (I'm working on landing all of the v10.x PRs in the order in which they were opened, so it's possible the conflicts were caused by something that recently landed on v10.x-staging).

@himself65
n-api: add napi_get_all_property_names
3909b7b 
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

PR-URL: nodejs#30006
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gabrielschulhof
Copy link
Contributor Author

@BethGriggs rebased. Sorry about the delay!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 28, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29440/ ✅

@gabrielschulhof gabrielschulhof mentioned this pull request Mar 2, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Mar 2, 2020
@himself65 @BethGriggs
n-api: add napi_get_all_property_names
ecbb331 
Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

PR-URL: #30006
Backport-PR-URL: #31384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs
Copy link
Member

Landed in ecbb331

@BethGriggs BethGriggs closed this Mar 2, 2020
@gabrielschulhof gabrielschulhof deleted the backport-30006-to-v10.x branch April 21, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

@addaleax addaleax Awaiting requested review from addaleax

@cjihrig cjihrig Awaiting requested review from cjihrig

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @nodejs-github-bot @BethGriggs @legendecas @mhdawson @himself65