Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up promise introspection #3130

Merged
merged 2 commits into from
Sep 30, 2015
Merged

Speed up promise introspection #3130

merged 2 commits into from
Sep 30, 2015

Commits on Sep 30, 2015

  1. util: optimize promise introspection 

    Use V8's builtin ObjectIsPromise() to check that the value is a promise
before creating the promise mirror.  Reduces garbage collector strain
in the (common) non-promise case, which is beneficial when inspecting
deep object graphs.

PR-URL: nodejs#3130
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @bnoordhuis
    bnoordhuis committed Sep 30, 2015
    Configuration menu
    Copy the full SHA
    9a1bc4e View commit details
    Browse the repository at this point in the history

  2. deps: backport f782159 from v8's upstream 

    Backport f78215962bf5de9d47c022e7baa3952d0bf6d17f from V8's upstream
to speed up promise introspection.

Original commit message:

  Remove obsolete try/catch from ObjectIsPromise().

  Review URL: https://codereview.chromium.org/1367123003

  Cr-Commit-Position: refs/heads/master@{nodejs#30966}

PR-URL: nodejs#3130
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    @bnoordhuis
    bnoordhuis committed Sep 30, 2015
    Configuration menu
    Copy the full SHA
    dbe4844 View commit details
    Browse the repository at this point in the history