Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explain native external types #31214

Closed
wants to merge 4 commits into from

Conversation

HarshithaKP
Copy link
Member

There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: nodejs#31173 (comment)
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Jan 6, 2020
doc/api/util.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR added the wip Issues and PRs that are still a work in progress. label Jan 6, 2020
@BridgeAR BridgeAR removed the wip Issues and PRs that are still a work in progress. label Jan 7, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2020
doc/api/util.md Outdated Show resolved Hide resolved
doc/api/util.md Outdated Show resolved Hide resolved
@gireeshpunathil
Copy link
Member

@gireeshpunathil
Copy link
Member

gireeshpunathil pushed a commit that referenced this pull request Jan 8, 2020
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@mscdex
Copy link
Contributor

mscdex commented Jan 8, 2020

@gireeshpunathil These commits just got pushed to master as-is.

@gireeshpunathil
Copy link
Member

@mscdex - saw the mistake, corrected it now. thanks!

@gireeshpunathil
Copy link
Member

landed in 95871a1

MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
There is a reference to native external types in
util.types.isExternal api documentation. Provide
a brief explanation to that.
Refs: #31173 (comment)

PR-URL: #31214
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants