lib: enhance use of Error from primordials #31163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
|
Refs: #30697 |
|
Does this have any impact on |
No, the object is the same as the global one. |
BridgeAR
approved these changes
Jan 2, 2020
BridgeAR
added
the
author ready
jasnell
approved these changes
Jan 2, 2020
devnexen
approved these changes
Jan 3, 2020
|
This PR is errored with the JS test suite in the "parallel/test-tick-processor-arguments" test ... i can reproduce the error now in my computer . i will investigate 😄 |
Sebastien-Ahkrin
force-pushed
the
ErrorPrimordials
branch
from
2b5695f to
9c1d309
Compare
@targos found the error 😄 so its only because the file v8-prof-polyfill can't contain any primordials. /* eslint-disable no-restricted-globals */I hope this will help you :) |
Trott
approved these changes
Jan 4, 2020
Trott
approved these changes
Jan 4, 2020
trivikr
approved these changes
Jan 4, 2020
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 4, 2020
PR-URL: nodejs#31163 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in c9b93e2 |
targos
pushed a commit
that referenced
this pull request
Jan 6, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31163 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Now, in this PR I have added Error in the primordials eslint
so have created a line in "/lib/.eslintrc.yaml".
And just import Error :).
I hope this new PR will help you :x