Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: allow writes after readable 'end' to finish #31082

Closed
wants to merge 3 commits into from

Commits on Dec 24, 2019

  1. zlib: allow writes after readable 'end' to finish

    Call the callback for writes that occur after the stream is closed.
    This also requires changes to the code to not call `.destroy()`
    on the stream in `.on('end')`, and to ignore chunks written
    afterwards.
    
    Previously, these writes would just queue up silently, as their
    `_write()` callback would never have been called.
    
    Fixes: nodejs#30976
    addaleax committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    dc16249 View commit details
    Browse the repository at this point in the history
  2. fixup! zlib: allow writes after readable 'end' to finish

    Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
    addaleax and lundibundi committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    af073c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2019

  1. fixup! zlib: allow writes after readable 'end' to finish

    Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax and bnoordhuis committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    a17b173 View commit details
    Browse the repository at this point in the history