lib: refactor NativeModule #30856
Closed
lib: refactor NativeModule #30856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the internal NativeModule class to a JS class and add more documentation about its properties.
lundibundi
approved these changes
Dec 8, 2019
aduh95
reviewed
Dec 8, 2019
| this.canBeRequiredByUsers = !id.startsWith('internal/'); | ||
|
|
||
| // The CJS exports object of the module. | ||
| this.exports = {}; |
There was a problem hiding this comment.
Wouldn't a public (or maybe private) field declaration be preferable?
class NativeModule {
exports = {};
#loaded = false;
#loading = false;
module = undefined;
exportKeys = undefined;
}I personally find it more readable than a declaration in the constructor, but that might just be me.
There was a problem hiding this comment.
i don't mind if private fields are used but i think we should keep field initialization in one spot (in this case, the constructor, since it assigns from arguments).
devsnek
approved these changes
Dec 8, 2019
Trott
approved these changes
Dec 13, 2019
Trott
added
the
author ready
|
Landed in e4e5a83 |
Trott
pushed a commit
that referenced
this pull request
Dec 14, 2019
Refactor the internal NativeModule class to a JS class and add more documentation about its properties. PR-URL: #30856 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Refactor the internal NativeModule class to a JS class and add more documentation about its properties. PR-URL: #30856 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Refactor the internal NativeModule class to a JS class and add more documentation about its properties. PR-URL: #30856 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Refactor the internal NativeModule class to a JS class and add more documentation about its properties. PR-URL: #30856 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the internal NativeModule class to a JS class and add
more documentation about its properties.
Tip: https://github.com/nodejs/node/pull/30856/files?w=1 is easier to review
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes