Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message #30728

Closed
wants to merge 4 commits into from
Closed

lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message #30728

wants to merge 4 commits into from

Conversation

qualitymanifest
Copy link
Contributor

  • default_resolve.js updated to pass parentURL into error
  • ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
  • test added to check for import message in error

Fixes: #30721

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 30, 2019
guybedford
guybedford reviewed Nov 30, 2019
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
guybedford
guybedford approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one on, looks great.

guybedford
guybedford reviewed Nov 30, 2019
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
@guybedford guybedford added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
BridgeAR
BridgeAR approved these changes Dec 2, 2019
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27293/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27315/

@addaleax addaleax added the esm Issues and PRs related to the ECMAScript Modules implementation. label Dec 3, 2019
@joaocgreis
Copy link
Member

Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/31957/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27335/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27338/

@qualitymanifest @guybedford
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION message
dba463e 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

Fixes: #30721
@qualitymanifest @guybedford
lib: add explicit ext to ERR_UNKNOWN_FILE_EXTENSION
c1c93bc
@qualitymanifest @guybedford
lib: quote ext in ERR_UNKNOWN_FILE_EXTENSION
dce3560
@qualitymanifest @guybedford
lib: remove quote escaping for ERR_UNKNOWN_FILE_EXTENSION
8fd0143
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27339/

@joaocgreis
Copy link
Member

Windows CI rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/32003/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27433/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27439/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27443/

guybedford pushed a commit that referenced this pull request Dec 7, 2019
@qualitymanifest @guybedford
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
7ab21b2 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@guybedford
Copy link
Contributor

Landed in 7ab21b2.

@guybedford guybedford closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@qualitymanifest @targos
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
2c439bb 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@qualitymanifest @MylesBorins
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
15d48f9 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@qualitymanifest @BethGriggs
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
1698a53 
- default_resolve updated to pass parentURL into error
- ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL
- test added to check for import message in error

PR-URL: #30728
Fixes: #30721
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@guybedford guybedford guybedford approved these changes

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esm: invalid extension error should provide parent context in error
9 participants
@qualitymanifest @nodejs-github-bot @joaocgreis @guybedford @jasnell @addaleax @lpinca @BridgeAR @trivikr