Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] Windows CI job update changes #30726

Conversation

joaocgreis
Copy link
Member

This is a backport of #30724 to v12. The changes are adapted for v10.

@nodejs/backporters I will update this with any feedback from the original PR. This needs to land soon after to avoid issues running CI.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x windows Issues and PRs related to the Windows platform. labels Nov 30, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@BethGriggs
Copy link
Member

@joaocgreis, as a FYI I don't think this will get a green CI until nodejs/build#2072 is resolved

@nodejs-github-bot
Copy link
Collaborator

@joaocgreis
Copy link
Member Author

@BethGriggs I see there was some progress in the issue, the last CI is green.

This, #30725 and #30727 are ready to land, which has to be done by a member of @nodejs/backporters according to the collaborator guide (or please let me know if I should do it).

@BethGriggs
Copy link
Member

@joaocgreis I can go through and land all of these

BethGriggs pushed a commit that referenced this pull request Dec 3, 2019
Backport-PR-URL: #30726
PR-URL: #30724
Refs: nodejs/build#1996
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 3, 2019
Don't exit vcbuild with error code 0 when cctest fails.

Backport-PR-URL: #30726
PR-URL: #30724
Refs: nodejs/build#1996
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs
Copy link
Member

Landed in 14e7a35...4d3ec1a

@BethGriggs BethGriggs closed this Dec 3, 2019
@joaocgreis
Copy link
Member Author

Thanks!

MylesBorins pushed a commit that referenced this pull request Dec 16, 2019
Backport-PR-URL: #30726
PR-URL: #30724
Refs: nodejs/build#1996
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
Don't exit vcbuild with error code 0 when cctest fails.

Backport-PR-URL: #30726
PR-URL: #30724
Refs: nodejs/build#1996
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants