build: fix static dll compilation on Windows #30695
Conversation
nodejs-github-bot
added
build
| @@ -720,6 +723,7 @@ | |||
| 'libraries': [ | |||
| 'Dbghelp', | |||
| 'Psapi', | |||
| 'Winmm', | |||
There was a problem hiding this comment.
If this is necessary to build v8_base, shouldn't this be placed in the v8 gypfiles? cc @targos @ryzokuken
There was a problem hiding this comment.
Possibly. What exactly in V8 uses Winmm APIs?
There was a problem hiding this comment.
#28845 (comment) was the initial explanation as to why I had to add it at this level, so potentially there is something wrong in the gyp configuration of v8?
Regarding what is using it exactly, it's the use of __imp_timeGetTime. From the errors (as shown in #28845 (comment)) I Googled it and the solution was to add Winmm.
|
@nodejs/platform-windows |
when compiling windows dll (shared mode), v8_libbase.vcxproj requires winmm.lib which are not being picked up by libnode. In the normal mode it is picked up via another dependency route. However, in the shared mode, the indirect dependency is not added. Fixes: #28845
When compiling node as a dll, libnode must be compiled as a lib instead of a dll. Having it compiled as a dll triggers node.vcxproj to compile libnode as a lib, meaning duplicate definitions appear causing the compiler to throw an error when compiling node Fixes: #28845
When compiling node in shared mode, the output should be a shared library rather than an executable. Fixes: #28845
|
This patch fixes Windows, but breaks Linux, AFAIK.
Simultaneously, out/Release/node is not generated under Linux. If I roll back the patch, everything is created just fine on Linux, but fails under Windows for the reasons you identified. |
|
excuse me, now I see the error again. |
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
|
I just tried this against master and was able to successfully build both x64 and x86. Given this i'll close this ticket. |
build: fix static dll compilation on Windows
This PR fixes the static dll compilation steps failing.
I'm uncertain about adding tests for this as I spotted in
the gyp files that shared mode isn't supported so to speak.
I tested this by running the following commands successfully:
.\vcbuild.bat dll.\vcbuild.bat dll x86Note: I encountered an issue when compiling a different
architecture after compiling the first for node 12 (though it
wasn't a problem against master). But if you delete the
outfolder after the first build, the second build will pass.
Fixes: #28845
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes