-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: improve performance by destructuring primordials #30447
Conversation
I'm actually getting a linter error on a line I didn't change (L538): defineProperty(Socket.prototype, 'bufferSize', {
get: function() { // eslint-disable-line getter-return
if (this._handle) {
return this[kLastWriteQueueSize] + this.writableLength;
}
}
}); Should I address that as part of this PR as well? |
Also, it looks like we usually go with capitalized |
Ooops, renamed. Thanks for bearing with me! |
landed in 5e4d99a, thanks for the contribution! |
Refs: #29766
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes