Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Use let instead of var for util/inspect.js #30399

Closed
wants to merge 3 commits into from
Closed

util: Use let instead of var for util/inspect.js #30399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2dd360
util: use let instead of var for util/inspect.js
lmammino Nov 12, 2019
c5b9ffd
util: use let instead of var for util/inspect.js
lmammino Nov 12, 2019
3fcc5b1
Merge branch 'fix/removes-var-from-inspect' of https://github.com/lma…
Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ function formatPrimitive(fn, value, ctx) {

function formatNamespaceObject(ctx, value, recurseTimes, keys) {
const output = new Array(keys.length);
for (var i = 0; i < keys.length; i++) {
for (let i = 0; i < keys.length; i++) {
try {
output[i] = formatProperty(ctx, value, recurseTimes, keys[i],
kObjectType);
Expand Down Expand Up @@ -1224,7 +1224,7 @@ function formatArray(ctx, value, recurseTimes) {

const remaining = valLen - len;
const output = [];
for (var i = 0; i < len; i++) {
for (let i = 0; i < len; i++) {
// Special handle sparse arrays.
if (!hasOwnProperty(value, i)) {
return formatSpecialArray(ctx, value, recurseTimes, len, output, i);
Expand Down Expand Up @@ -1300,7 +1300,7 @@ function formatSetIterInner(ctx, recurseTimes, entries, state) {
const maxLength = Math.min(maxArrayLength, entries.length);
let output = new Array(maxLength);
ctx.indentationLvl += 2;
for (var i = 0; i < maxLength; i++) {
for (let i = 0; i < maxLength; i++) {
output[i] = formatValue(ctx, entries[i], recurseTimes);
}
ctx.indentationLvl -= 2;
Expand Down Expand Up @@ -1468,7 +1468,7 @@ function isBelowBreakLength(ctx, output, start, base) {
let totalLength = output.length + start;
if (totalLength + output.length > ctx.breakLength)
return false;
for (var i = 0; i < output.length; i++) {
for (let i = 0; i < output.length; i++) {
if (ctx.colors) {
totalLength += removeColors(output[i]).length;
} else {
Expand Down Expand Up @@ -1589,7 +1589,7 @@ function formatWithOptionsInternal(inspectOptions, ...args) {
let tempStr;
let lastPos = 0;

for (var i = 0; i < first.length - 1; i++) {
for (let i = 0; i < first.length - 1; i++) {
if (first.charCodeAt(i) === 37) { // '%'
const nextChar = first.charCodeAt(++i);
if (a + 1 !== args.length) {
Expand Down