[v10.x backport] buffer: add {read|write}Big[U]Int64{BE|LE} methods #30361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
Backport-PR-URL: nodejs#30361 PR-URL: nodejs#19691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> (cherry picked from commit 3d8532f)
GaryGSC
force-pushed
the
backport-19691-to-v10.x
branch
from
9642c33
to
4a6d911
Compare
|
I'd appreciate it if someone could start the |
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Nov 13, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It turns out the first few resume build CI's were failing as the fanned Windows builds only store binaries for 7 days, so this PR needed a full rerun (thanks for the info @richardlau). One more CI 🤞 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI is green now that nodejs/build#2070 and nodejs/build#2072 have been resolved 🎉 |
BethGriggs
approved these changes
Dec 2, 2019
BethGriggs
added
the
semver-minor
MylesBorins
force-pushed
the
v10.x-staging
branch
from
99915bc
to
8f3b8ca
Compare
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/29251/ ✅ |
BethGriggs
pushed a commit
that referenced
this pull request
Feb 25, 2020
Backport-PR-URL: #30361 PR-URL: #19691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in 64744a2 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #19691
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Tiancheng "Timothy" Gu timothygu99@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Matteo Collina matteo.collina@gmail.com
(cherry picked from commit 3d8532f)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes