Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace var with const/let in test/parallel/test-whatwg-url-set… #30250

Closed
wants to merge 1 commit into from
Closed

test: replace var with const/let in test/parallel/test-whatwg-url-set… #30250

wants to merge 1 commit into from

Conversation

peze
Copy link
Contributor

@peze peze commented Nov 4, 2019 •
edited
Loading

test: replace var with const/let in test/parallel/test-whatwg-url-setters.js

Refs: nodejs/code-and-learn#97

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2019
@trivikr trivikr added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Nov 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26331/

joyeecheung
joyeecheung requested changes Nov 4, 2019
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the comment on L19-20 of this file

@peze peze closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung requested changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peze @nodejs-github-bot @joyeecheung @trivikr