Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: remove listeners on bind error #30210

Closed
wants to merge 3 commits into from
Closed

dgram: remove listeners on bind error #30210

wants to merge 3 commits into from

Commits on Nov 1, 2019

  1. dgram: reset bind state before emitting error 

    This was previously done inconsistently, sometimes before, sometimes
after emitting the event.
    @addaleax
    addaleax committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e17fcc8 View commit details
    Browse the repository at this point in the history

  2. dgram: remove listeners on bind error 

    This avoids piling up `'listening'` event listeners if
`.bind()` fails repeatedly.

Fixes: nodejs#30209
    @addaleax
    addaleax committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    2d8aa64 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2019

  1. fixup! dgram: remove listeners on bind error

    @addaleax
    addaleax committed Nov 2, 2019
    Configuration menu
    Copy the full SHA
    f603ff4 View commit details
    Browse the repository at this point in the history