build: fixes build for some os versions #30141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
devnexen
force-pushed
the
centos_build_issue_fix
branch
from
9d8b2b4 to
9e8215f
Compare
addaleax
approved these changes
Oct 27, 2019
targos
reviewed
Oct 27, 2019
bnoordhuis
requested changes
Oct 27, 2019
devnexen
force-pushed
the
centos_build_issue_fix
branch
from
9e8215f to
3ff8113
Compare
richardlau
reviewed
Oct 27, 2019
devnexen
force-pushed
the
centos_build_issue_fix
branch
from
3ff8113 to
67a7e89
Compare
richardlau
approved these changes
Oct 27, 2019
bnoordhuis
approved these changes
Oct 29, 2019
targos
reviewed
Oct 29, 2019
| @@ -355,7 +355,8 @@ | |||
| }], | |||
| [ 'OS in "linux freebsd openbsd solaris android aix cloudabi"', { | |||
| 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ], | |||
| 'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++1y' ], | |||
| 'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++1y'], | |||
| 'defines': ['__STDC_FORMAT_MACROS' ], | |||
There was a problem hiding this comment.
Suggested change
| 'defines': ['__STDC_FORMAT_MACROS' ], | |
| 'defines': [ '__STDC_FORMAT_MACROS' ], |
|
Any progress in merging? Any plan for release update? |
devnexen
force-pushed
the
centos_build_issue_fix
branch
2 times, most recently
from
f763019 to
14b017c
Compare
gengjiawen
approved these changes
Nov 9, 2019
|
Whoever lands this, please make sure to fix the whitespace change pointed out above (#30141 (comment)) |
For format macros, the __STDC_FORMAT_MACROS flag needs to be passed, also passing the librt linker flag.
devnexen
force-pushed
the
centos_build_issue_fix
branch
from
14b017c to
3f19733
Compare
BridgeAR
added
the
author ready
|
Landed in bdb1194 |
|
Actually landed in 18de9ba without metadata. |
targos
referenced
this pull request
Jan 6, 2020
For format macros, the __STDC_FORMAT_MACROS flag needs to be passed, also passing the librt linker flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For format macros, the __STDC_FORMAT_MACROS flag needs to be
passed, also passing the librt linker flag.
Fixes #30077