-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix return type #29696
doc: fix return type #29696
Conversation
@nodejs/crypto |
If this will be accepted, we also need to update the type parser, i.e. to add an entry after this line: Line 54 in 7333c71
|
It will have to happen in this PR or else |
@nodejs/crypto @nodejs/documentation This could use reviews. |
@nodejs/collaborators |
Rebased and force-pushed. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3970/ |
PR-URL: #29696 Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in 03b7a5a |
PR-URL: #29696 Reviewed-By: Rich Trott <rtrott@gmail.com>
IIUC,
crypto.createDiffieHellmanGroup(name)
and its originalcrypto.getDiffieHellman(groupName)
will return a instance ofDiffieHellmanGroup
which is not a sub type ofDiffieHellman
.on Node.js v12.10.0.
Checklist