[x] stream: don't call _read after destroy() #29485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ronag
force-pushed
the
read-after-destroy
branch
from
9c3f707
to
995f432
Compare
ronag
commented
Sep 7, 2019
| transform.removeListener('finish', fail); | ||
| transform.on('end', common.mustCall()); | ||
| transform.on('finish', common.mustCall()); | ||
| } |
There was a problem hiding this comment.
This test doesn't seem to be testing correct behaviour. We should not have either 'end' nor 'finish' after destroy().
ronag
force-pushed
the
read-after-destroy
branch
3 times, most recently
from
58d1e79
to
7083dc8
Compare
ronag
force-pushed
the
read-after-destroy
branch
from
7083dc8
to
593e6b2
Compare
|
This needs more work. Simpler version on the way. |
ronag
changed the title
This was referenced Sep 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop flowing once destroyed.
Currently stream implementation MUST check for
destroyedinside_read.Found this while investigating a suspicious
destroyedconditional infsstreams.This is semver major unfortunately. The existing behaviour is to flush the readable and invoke
endafterdestroy(). See updated tests.If preferable I can make a less breaking version of this (instead of or as an intermediate?) that just makes sure
_readis not called afterdestroy(). Though it does not fully "correct" the behaviour.Refs: #29477
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes