http2: send out pending data earlier #29398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there’s a lot of data waiting on a given stream, send it out early, if possible. This helps trigger the backpressure mechanism introduced in 8a4a193 at a better time.
addaleax
added
http2
nodejs-github-bot
added
the
c++
antsmartian
reviewed
Sep 2, 2019
| @@ -1186,7 +1186,10 @@ int Http2Session::OnDataChunkReceived(nghttp2_session* handle, | |||
| stream->inbound_consumed_data_while_paused_ += avail; | |||
|
|
|||
| // If we have a gathered a lot of data for output, try sending it now. | |||
| if (session->outgoing_length_ > 4096) session->SendPendingData(); | |||
| if (session->outgoing_length_ > 4096 || | |||
There was a problem hiding this comment.
nit: not a c++ expert, but we can move 4096 to variable and re-use.
devnexen
approved these changes
Sep 2, 2019
jasnell
approved these changes
Sep 3, 2019
|
Landed in 1cde519 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 7, 2019
If there’s a lot of data waiting on a given stream, send it out early, if possible. This helps trigger the backpressure mechanism introduced in 8a4a193 at a better time. PR-URL: nodejs#29398 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Sep 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there’s a lot of data waiting on a given stream, send
it out early, if possible. This helps trigger the backpressure
mechanism introduced in 8a4a193 at a better time.
(Will look into writing tests for this.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes