-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove flaky status for test-statwatcher #29392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
Issues and PRs related to the async hooks subsystem.
test
Issues and PRs related to the tests.
labels
Sep 1, 2019
bnoordhuis
approved these changes
Sep 1, 2019
cjihrig
approved these changes
Sep 1, 2019
targos
approved these changes
Sep 1, 2019
gengjiawen
approved these changes
Sep 1, 2019
trivikr
approved these changes
Sep 1, 2019
lpinca
approved these changes
Sep 1, 2019
devnexen
approved these changes
Sep 1, 2019
patilharshal16
approved these changes
Sep 2, 2019
Landed in f2c573c |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
test-statwatcher does not appear to be failing anymore in CI. Remove "flaky" status for the test. Closes: #21425 PR-URL: #29392 Fixes: #21425 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_hooks
Issues and PRs related to the async hooks subsystem.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-statwatcher does not appear to be failing anymore in CI. Remove
"flaky" status for the test.
Closes: #21425
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes