Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: consistent perms of signed release files #29350

Closed

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 28, 2019

Fixes: nodejs/build#1904

v12.9.1 went out with .sig and .asc files mode 600 so were 403 Forbidden. I believe this is because file permissions are simply copied from what they were when the releaser makes the signature files. All other files in the release directory are already 644 just prior to signing and uploading signed files: https://github.com/nodejs/build/blob/f95ffc8d7d9930f1bc9505b016fdd84711916759/setup/www/tools/promote/_resha.sh#L25-L26

This is only testable by a releaser so I'd appreciate the next person doing a release to run this copy of tools/release.sh rather than the one currently on master & v12.x. Once we confirm the release is 👍 we can merge this and make sure it's on all active release branches. @nodejs/releasers.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg
Copy link
Member Author

rvagg commented Aug 30, 2019

thanks for the reviews, will hold this up from landing until it's actually tested by a releaser, after that it can land.

@BridgeAR
Copy link
Member

@rvagg I suggest we land this now and we can still revert this if it would turn out not to work as expected?

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020
@Trott
Copy link
Member

Trott commented Jan 12, 2020

Landed in 625a81d

@Trott Trott closed this Jan 12, 2020
Trott pushed a commit that referenced this pull request Jan 12, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@rvagg rvagg deleted the rvagg/release-signed-files-permissions-fix branch January 13, 2020 02:33
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Jan 16, 2020
codebytere pushed a commit that referenced this pull request Mar 14, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Fixes: nodejs/build#1904

PR-URL: #29350
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect permissions on SHASUMS256.txt.asc and SHASUMS256.txt.sig for v12.9.1
8 participants