Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: test Python 3.6 and 3.7 on Travis CI #29291

Closed
wants to merge 1 commit into from
Closed

build: test Python 3.6 and 3.7 on Travis CI #29291

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 24, 2019 •
edited
Loading

Add a Python 3.6 experimental run to Travis CI because the Python 3.7 run fails early because async is a reserved word in Python >= 3.7.

help wanted:

  1. How can we get the Python 3.6 build to complete before timing out (50 minutes)?
  2. How can we fix the async issue on Python >= 3.7?
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 24, 2019
@cclauss cclauss added python PRs and issues that require attention from people who are familiar with Python. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Aug 24, 2019
@cclauss cclauss mentioned this pull request Aug 26, 2019
Closed
63 tasks
@Trott
Copy link
Member

Trott commented Aug 27, 2019

Gratuitous lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3860/

Trott pushed a commit that referenced this pull request Aug 27, 2019
@cclauss @Trott
build: test Python 3.6 and 3.7 on Travis CI
bfa2683 
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 27, 2019

Landed in bfa2683

@Trott Trott closed this Aug 27, 2019
@cclauss cclauss deleted the test-Python-3.6-on-Travis-CI branch August 27, 2019 05:34
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@cclauss @BridgeAR
build: test Python 3.6 and 3.7 on Travis CI
164075e 
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@cclauss @BridgeAR
build: test Python 3.6 and 3.7 on Travis CI
def5c3e 
PR-URL: #29291
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@richardlau richardlau Awaiting requested review from richardlau

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cclauss @Trott @gengjiawen @trivikr @nodejs-github-bot