Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: consolidate lazyErrmapGet() #29285

Closed
wants to merge 1 commit into from
Closed

lib: consolidate lazyErrmapGet() #29285

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 23, 2019

There are currently two implementations of this function. This commit removes the redundancy, and removes "lazy" from the name.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
lib: consolidate lazyErrmapGet()
73374c1 
There are currently two implementations of this function.
This commit removes the redundancy, and removes "lazy" from
the name.
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module. labels Aug 23, 2019
@cjihrig cjihrig mentioned this pull request Aug 23, 2019
Closed
3 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 24, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/25213/

EDIT: CI was green.

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 24, 2019
@Trott
Copy link
Member

Trott commented Aug 25, 2019

Landed in 627bf59

@Trott Trott closed this Aug 25, 2019
Trott pushed a commit that referenced this pull request Aug 25, 2019
@cjihrig @Trott
lib: consolidate lazyErrmapGet()
627bf59 
There are currently two implementations of this function.
This commit removes the redundancy, and removes "lazy" from
the name.

PR-URL: #29285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig deleted the combine branch August 25, 2019 23:47
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@cjihrig @BridgeAR
lib: consolidate lazyErrmapGet()
902fc2f 
There are currently two implementations of this function.
This commit removes the redundancy, and removes "lazy" from
the name.

PR-URL: #29285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@cjihrig @BridgeAR
lib: consolidate lazyErrmapGet()
6e585fb 
There are currently two implementations of this function.
This commit removes the redundancy, and removes "lazy" from
the name.

PR-URL: #29285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @Trott @jasnell @lpinca @trivikr