Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "stream: do not emit drain if stream ended" #29272

Closed
wants to merge 1 commit into from
Closed

Revert "stream: do not emit drain if stream ended" #29272

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

This reverts commit 605d7c4 following up from the discussion in #29086 (comment).

Please 👍 for fast-track.

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes

  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Aug 22, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25186/

@mcollina
Copy link
Member Author

cc @isaacs

@isaacs
Copy link
Contributor

isaacs commented Aug 22, 2019

Digging into this further based on feedback from @ronag. Might have an update in an hour or two.

@isaacs
Copy link
Contributor

isaacs commented Aug 22, 2019

I suggest reverting bdf07f4 instead of (or in addition to) this, to fix the TCP drain event emitter warnings. (Via @ronag, and tested locally.)

@isaacs
Copy link
Contributor

isaacs commented Aug 22, 2019

Digging into it further, I don't think that 605d7c4 is as much of a problem as I'd originally suspected. I was mistaken. I'm now -1 on this PR, and withdraw my original suggestion. bdf07f4 is definitely the culprit.

@mcollina mcollina closed this Aug 22, 2019
@mcollina
Copy link
Member Author

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Awaiting requested review from Trott

@addaleax addaleax Awaiting requested review from addaleax

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mcollina @nodejs-github-bot @isaacs @jasnell @Fishrock123 @cjihrig