Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make pty_helper.py python3-compatible #29167

Closed
wants to merge 1 commit into from
Closed

tools: make pty_helper.py python3-compatible #29167

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Aug 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25029/

@bnoordhuis
Copy link
Member Author

I suppose the proper prefix is 'test:' because the script lives in test/pseudo-tty. It's invoked by tools/test.py though.

@sam-github
Copy link
Contributor

sam-github commented Aug 16, 2019 •
edited
Loading

Isn't covered by current tests, since they just do py2, but I did a python3 tools/test.py -J pseudo-tty and it works.

@cclauss cclauss mentioned this pull request Aug 16, 2019
Closed
63 tasks
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2019
@Trott
Copy link
Member

Trott commented Aug 19, 2019

Landed in 9c27118

@Trott Trott closed this Aug 19, 2019
Trott pushed a commit that referenced this pull request Aug 19, 2019
@bnoordhuis @Trott
tools: make pty_helper.py python3-compatible
9c27118 
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 20, 2019
@bnoordhuis @targos
tools: make pty_helper.py python3-compatible
acdc21b 
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pty_helper.py doesn't work with python3
5 participants
@bnoordhuis @nodejs-github-bot @sam-github @Trott @addaleax