build: py3 configure.py #29106
Closed
build: py3 configure.py #29106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
addaleax
approved these changes
Aug 13, 2019
cclauss
added
the
python
targos
approved these changes
Aug 13, 2019
richardlau
approved these changes
Aug 13, 2019
4 tasks
sam-github
approved these changes
Aug 13, 2019
gengjiawen
approved these changes
Aug 14, 2019
patilharshal16
approved these changes
Aug 14, 2019
This was referenced Aug 14, 2019
4 tasks
sam-github
force-pushed
the
Py3_configure.py
branch
from
4fcbdcc
to
9583336
Compare
sam-github
force-pushed
the
Py3_configure.py
branch
from
9583336
to
10fb24a
Compare
sam-github
approved these changes
Aug 15, 2019
Trott
approved these changes
Aug 16, 2019
|
Landed in a582c6b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 16, 2019
PR-URL: nodejs#29106 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29106 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
BaochengSu
pushed a commit
to BaochengSu/node
that referenced
this pull request
Oct 20, 2020
PR-URL: nodejs#29106 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> (cherry picked from commit a582c6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 does not make a distinction between bytes and str while Python 3 strictly enforces the difference.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes