benchmark: allow easy passing of process flags #28986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Aug 6, 2019
jasnell
approved these changes
Aug 7, 2019
mscdex
force-pushed
the
benchmark-prof-feature
branch
from
6dcf3e9 to
4083bbc
Compare
Trott
approved these changes
Aug 7, 2019
|
@bnoordhuis @jasnell I've decided to generalize this because the ability to use other flags (e.g. |
|
Benchmark test run: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8413/ (queued, will 404 until a worker is available) |
Trott
added
the
author ready
bnoordhuis
approved these changes
Aug 7, 2019
benchmark/common.js
Outdated
| @@ -25,6 +25,8 @@ function Benchmark(fn, configs, options) { | |||
| if (options && options.flags) { | |||
| this.flags = this.flags.concat(options.flags); | |||
| } | |||
| if (process.env.NODE_BENCHMARK_FLAGS) | |||
| this.flags = this.flags.concat(process.env.NODE_BENCHMARK_FLAGS.split(' ')); | |||
There was a problem hiding this comment.
Maybe split on /\s+/? Otherwise env NODE_BENCHMARK_FLAGS="--foo --bar" node bench.js (note the double space) produces three flags, one of them the empty string.
mscdex
force-pushed
the
benchmark-prof-feature
branch
from
4083bbc to
c0358a8
Compare
mscdex
changed the title
apapirovski
approved these changes
Aug 7, 2019
trivikr
approved these changes
Aug 7, 2019
jasnell
approved these changes
Aug 7, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 8, 2019
PR-URL: nodejs#28986 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in fd8d44f |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #28986 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 20, 2019
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, using
--profwhen running benchmarks also produces separate profiler output for the benchmark runner itself, which is generally not helpful. With this change, it's quick and easy to know which profiler output file to look at.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes