Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct import statement #28876

Closed
wants to merge 2 commits into from
Closed

docs: correct import statement #28876

wants to merge 2 commits into from

Conversation

himself65
Copy link
Member

fix #28861

JSON file can be imported now

// index.mjs
import pkg from  '../package.json'
console.log(pkg)
Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 27, 2019
@Trott
Copy link
Member

Trott commented Jul 27, 2019

Should JSON be added to the previous line listing allowable things to import?

@himself65
Copy link
Member Author

@Trott added

@himself65
doc: correct import statement
849ca9d 
JSON file can be imported now
@trivikr trivikr requested a review from Trott July 29, 2019 04:10
@Trott
Copy link
Member

Trott commented Jul 29, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3810/

@cjihrig @lpinca Still LGTY?

@cjihrig
Copy link
Contributor

cjihrig commented Jul 29, 2019

Still LGTM

@Trott
Copy link
Member

Trott commented Jul 29, 2019

Landed in 8a10b50

@Trott Trott closed this Jul 29, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 29, 2019
@himself65 @Trott
doc: correct import statement
8a10b50 
JSON file can be imported now

PR-URL: nodejs#28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
@himself65 @targos
doc: correct import statement
5533d48 
JSON file can be imported now

PR-URL: #28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: json support with node@12.7 esm modules
5 participants
@himself65 @Trott @cjihrig @lpinca @nodejs-github-bot