Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] readline: revert semver-major of 28109 #28157

Closed
wants to merge 2 commits into from
Closed

[v12.x] readline: revert semver-major of 28109 #28157

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github
readline: error on falsy values for callback
006cda5 
It was intended, according to in-test comments and common behaviour,
that callbacks be either `undefined` or a function, but falsy values
were being accepted as meaning "no callback".

PR-URL: nodejs#28109
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sam-github
readline: revert semver-major of 28109
f832e86 
PR-URL: nodejs#28109
@nodejs-github-bot
Copy link
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v12.x labels Jun 10, 2019
@sam-github
Copy link
Contributor Author

@BridgeAR I'm not sure this is actually a useful backport of #28109, or how it is you structure this kind of thing, I had trouble finding an example in my quick look at the history.

What do you think? Close if its not useful.

@BridgeAR
Copy link
Member

Hm, in this specific case backporting the change does indeed not seem to provide much benefit. We do not yet have any example around it but that's a good idea and I'll raise an issue in the release working group about it!

I'll go ahead and close this, but thanks a lot for doing this nevertheless!

@BridgeAR BridgeAR closed this Jun 12, 2019
@sam-github
Copy link
Contributor Author

As you wish, though notice it does add regression checks for a current (odd) behaviour.

@sam-github sam-github deleted the backport-28109-v12.x branch June 12, 2019 18:12
@sam-github
Copy link
Contributor Author

Not to say it should land... I'm on the fence, too.

@BridgeAR
Copy link
Member

Hm, I would be fine with landing that regression test as well but I guess it's not required on 12 since master has a test for it and the only thing that could break it should likely be a bad backport (or a Node.js 12 specific PR but those are rare)?

@BridgeAR
Copy link
Member

Refs: nodejs/Release#459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sam-github @nodejs-github-bot @BridgeAR