Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: unbreak --with-intl=system-icu build #28118

Closed
wants to merge 3 commits into from
Closed

build: unbreak --with-intl=system-icu build #28118

wants to merge 3 commits into from

Commits on Jun 7, 2019

  1. build: don't swallow pkg-config warnings

    @bnoordhuis
    bnoordhuis committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    aa5e4cc View commit details
    Browse the repository at this point in the history

  2. build: fix icu-i18n pkg-config version check 

    The pkg_config() helper can either return a tuple of None values
(no pkg-config installed) and that was what the check was testing
for, but it can also return a tuple of empty strings when the
package isn't installed.
    @bnoordhuis
    bnoordhuis committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    1a62bc8 View commit details
    Browse the repository at this point in the history

  3. build: unbreak --with-intl=system-icu build 

    Include directories are configured by the tools/icu/icu-*.gyp files.
The v8.gyp file doesn't need to add them and in fact the way it did
that breaks when building against an external copy of ICU.

Fixes: nodejs#28052
    @bnoordhuis
    bnoordhuis committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    167f4b0 View commit details
    Browse the repository at this point in the history