Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: try to reduce flakes on Windows #28035

Merged
merged 4 commits into from
Jun 6, 2019
Merged

test: try to reduce flakes on Windows #28035

merged 4 commits into from
Jun 6, 2019

Commits on Jun 6, 2019

  1. test: shell out to rmdir first on Windows 

    cmd's `rmdir` is hardened to deal with Windows edge cases, like
lingering processes, indexing, and AV checks. So we give it a try first.

* Added `opts = { spawn = true }` to opt-out of spawning
* test-pipeconnectwrap.js - spawning messes up async_hooks state

PR-URL: nodejs#28035
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @refack
    refack committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    59f666c View commit details
    Browse the repository at this point in the history

  2. test: always suffix tmpdir 

    This makes temp dir names consistent whether we run in stand-alone mode,
via `test.py` in single process, or in multi-process.

PR-URL: nodejs#28035
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @refack
    refack committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    9032ab4 View commit details
    Browse the repository at this point in the history

  3. test: regression test tmpdir 

    PR-URL: nodejs#28035
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @refack
    refack committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    2f8cf5e View commit details
    Browse the repository at this point in the history

  4. test: mark test-worker-debug as flaky 

    Also try to make more traceable.

PR-URL: nodejs#28035
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    @refack
    refack committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    65a5f7b View commit details
    Browse the repository at this point in the history