Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use Calls over Executes for Consistency #2800

Closed
wants to merge 1 commit into from
Closed

Docs: use Calls over Executes for Consistency #2800

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

Calls are used frequently through the doc except this line
use Calls over Executes to make it consistent

Calls are used frequently through the doc except this line
use Calls over Executes to make it consistent
@mscdex mscdex added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 10, 2015
@Trott
Copy link
Member

Trott commented Sep 10, 2015

LGTM

1 similar comment
@Fishrock123
Copy link
Contributor

LGTM

@Fishrock123
Copy link
Contributor

Thanks, landed in def945c70f593f71124bbbf2052bb5c9acb68eec

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 11, 2015
"Calls" is used frequently throughout the docs except for this line.
Use "Calls" over "Executes" to make it consistent.

PR-URL: nodejs#2800
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Ahh I got the subsystem wrong. (doc:) actually landed in 958a94e

@Fishrock123 Fishrock123 reopened this Sep 11, 2015
rvagg pushed a commit that referenced this pull request Sep 12, 2015
"Calls" is used frequently throughout the docs except for this line.
Use "Calls" over "Executes" to make it consistent.

PR-URL: #2800
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Sep 12, 2015
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
7 tasks
Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
"Calls" is used frequently throughout the docs except for this line.
Use "Calls" over "Executes" to make it consistent.

PR-URL: #2800
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants