-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: set tlsSocket.servername as early as possible #27759
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1033,6 +1033,11 @@ int TLSWrap::SelectSNIContextCallback(SSL* s, int* ad, void* arg) { | |
Local<Object> object = p->object(); | ||
Local<Value> ctx; | ||
|
||
// Set the servername as early as possible | ||
Local<Object> owner = p->GetOwner(); | ||
USE(owner->Set(env->context(), env->servername_string(), | ||
OneByteString(env->isolate(), servername))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tiny style nit: can you line up the arguments? I'm a little ambivalent about discarding the return value with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Done.
Good reminding! I think returning |
||
|
||
if (!object->Get(env->context(), env->sni_context_string()).ToLocal(&ctx)) | ||
return SSL_TLSEXT_ERR_NOACK; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
const assert = require('assert'); | ||
const tls = require('tls'); | ||
|
||
// We could get the `tlsSocket.servername` even if the event of "tlsClientError" | ||
// is emitted. | ||
|
||
const serverOptions = { | ||
requestCert: true, | ||
rejectUnauthorized: false, | ||
SNICallback: function(servername, callback) { | ||
if (servername === 'c.another.com') { | ||
callback(null, {}); | ||
} else { | ||
callback(new Error('Invalid SNI context'), null); | ||
} | ||
} | ||
}; | ||
|
||
function test(options) { | ||
const server = tls.createServer(serverOptions, common.mustNotCall()); | ||
|
||
server.on('tlsClientError', common.mustCall((err, socket) => { | ||
assert.strictEqual(err.message, 'Invalid SNI context'); | ||
// The `servername` should match. | ||
assert.strictEqual(socket.servername, options.servername); | ||
})); | ||
|
||
server.listen(0, () => { | ||
options.port = server.address().port; | ||
const client = tls.connect(options, common.mustNotCall()); | ||
|
||
client.on('error', common.mustCall((err) => { | ||
assert.strictEqual(err.message, 'Client network socket' + | ||
' disconnected before secure TLS connection was established'); | ||
})); | ||
|
||
client.on('close', common.mustCall(() => server.close())); | ||
}); | ||
} | ||
|
||
test({ | ||
port: undefined, | ||
servername: 'c.another.com', | ||
rejectUnauthorized: false | ||
}); | ||
|
||
test({ | ||
port: undefined, | ||
servername: 'c.wrong.com', | ||
rejectUnauthorized: false | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be specific here and say "set by TLSWrap::SelectSNIContextCallback()"? That should save the next guy/gal some searching.
Would it make sense to make the assignment conditional on
if (this.servername === undefined)
to avoid duplicate work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Yes, it makes sense to me. And the default value of
this.servername
isnull
so that I have usedif (this.servername === null)
instead.